#11447 closed (fixed)
foreign keys need class nowrap for td in changelist
| Reported by: | Owned by: | nobody | |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
in admin_list.py, line 184 insert:
row_class = ' class="nowrap"'
otherwise, the add_another-button is in the next line if the screen is too small.
Attachments (1)
Change History (9)
comment:1 by , 15 years ago
| Version: | 1.0 → SVN |
|---|
comment:2 by , 15 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
by , 14 years ago
| Attachment: | 11447_fk_nowrap.diff added |
|---|
comment:3 by , 14 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:4 by , 14 years ago
| Triage Stage: | Ready for checkin → Accepted |
|---|
For future reference -- this might not need tests, but it certainly needs an clearer explanation. I eventually worked out that this was referring to the wrapping behavior of a changelist when list_editable is in use, but it's vastly preferable to not have to do that sort of detective work.
comment:5 by , 14 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
comment:6 by , 14 years ago
Also - you may not need to add a test, but you should *run* the tests. Patch as provided breaks two tests regressiontests/admin_changelist.
Note:
See TracTickets
for help on using tickets.
This seems trivial enough to directly promote to RFC. I don't think this needs tests.