#11350 closed (fixed)
Support "local flavor" for Israel
| Reported by: | Yuval Adam | Owned by: | Yuval Adam |
|---|---|---|---|
| Component: | contrib.localflavor | Version: | dev |
| Severity: | Keywords: | local flavor israel | |
| Cc: | Shai Berger | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
Support django.contrib.localflavor for Israel
Attachments (7)
Change History (23)
comment:1 by , 15 years ago
| Owner: | changed from to |
|---|---|
| Status: | new → assigned |
comment:2 by , 15 years ago
| Owner: | changed from to |
|---|---|
| Status: | assigned → new |
by , 15 years ago
comment:3 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 by , 15 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
A ticket isn't fixed because a patch is uploaded, it's fixed when the code goes into Django.
comment:5 by , 15 years ago
| Needs tests: | set |
|---|
Also please add some tests to the forms you included. That way everybody will know if their work broke your code and would be able to fix it.
comment:6 by , 15 years ago
| milestone: | 1.1 |
|---|
We are well past the feature deadline for v1.1. This will need to wait until the next development phase.
comment:7 by , 15 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
comment:8 by , 15 years ago
| Needs documentation: | set |
|---|---|
| Needs tests: | unset |
| Patch needs improvement: | set |
Please provide a proper diff of the changes and a little bit of documentation.
comment:9 by , 15 years ago
| Cc: | added |
|---|
comment:10 by , 14 years ago
| Has patch: | set |
|---|---|
| milestone: | → 1.3 |
| Needs documentation: | unset |
| Patch needs improvement: | unset |
comment:11 by , 14 years ago
Does anyone know where I can find a description of the Israeli ID specification, google yields nothing of use.
comment:12 by , 14 years ago
Google yields plenty of results when you search in Hebrew... by following them, I got to the Luhn Algorithm -- the standard "mod 10" variant; numbers are 8 digits + checksum (9 digits altogether).
comment:13 by , 14 years ago
FYI, there is a luhn function in django.utils.checksums that is used by at least one localflavor.
by , 14 years ago
| Attachment: | django-11350.2.diff added |
|---|
Use the luhn function as suggested by jezdez.
comment:14 by , 14 years ago
Relevant (hebrew) wikipedia entries: the ID number format: the ID number format,
the checksum algorithm.
by , 14 years ago
| Attachment: | django-11350.3.diff added |
|---|
Adds checking for hyphenated checksum, cited references.
comment:15 by , 14 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Forms for Israel local flavor