Wrong default-character-set in MySQL 4.1x/5.x (win32)

[hipertracker@…]

Django do not correctly display content from MySQL 4.1x, 5.x for win32. It always assume using latin1_swedish_ci
as default encoding instead of using settings (default-character-set=utf8) in my.ini.

Solution:

In Django-0.90-py2.4.egg\django\core\db\backends\mysql.py
change method cursor():

def cursor(self):

...

# OLD code:

# if DEBUG:
# return base.CursorDebugWrapper(MysqlDebugWrapper(self.connection.cursor()), self)
#return self.connection.cursor()

# NEW code:
if self.connection.get_server_info() >= '4.1':

cursor = self.connection.cursor()
cursor.execute("SET NAMES utf8")
if DEBUG:

return base.CursorDebugWrapper(MysqlDebugWrapper(cursor), self)

return cursor

[hipertracker@…]

correctly formated code

[anonymous]

agreed

doing this patch by hands each svn-update :-)

[hipertracker@…]

The corrected code (cursor should be defined above if ...):

cursor = self.connection.cursor()
if self.connection.get_server_info() >= '4.1':
    cursor.execute("SET NAMES utf8")
    if DEBUG:
        return base.CursorDebugWrapper(MysqlDebugWrapper(cursor), self)
return cursor  

[anonymous]

Shouldn't the debug conditional be outside the server version conditonal?

cursor = self.connection.cursor()
if self.connection.get_server_info() >= '4.1':
    cursor.execute("SET NAMES utf8")
if DEBUG:
    return base.CursorDebugWrapper(MysqlDebugWrapper(cursor), self)
return cursor

?

[hipertracker@…]

Yes, of course.

[Adrian Holovaty]

(In [1878]) Fixed #1121 -- Changed MySQL backend to use correct character set in MySQL 4.1x/5.x on Win32. Thanks, hipertracker@…