Opened 15 years ago

Closed 15 years ago

Last modified 13 years ago

#11123 closed (fixed)

Irish localflavor

Reported by: Michael Thornhill Owned by: nobody
Component: contrib.localflavor Version: 1.0
Severity: Keywords: Ireland ie
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Irish localflavor contribution with county names

Attachments (1)

ie.tar.gz (797 bytes ) - added by Michael Thornhill 15 years ago.
ie localflavor with County removed from all county names and unneccesary imports removed

Download all attachments as: .zip

Change History (9)

comment:1 by Russell Keith-Magee, 15 years ago

milestone: 1.1
Triage Stage: UnreviewedAccepted

Thanks for the contribution. However, the feature deadline for v1.1 has passed; we can look at this for the next release.

comment:2 by dc, 15 years ago

Patch needs improvement: set

forms.py imports many things but only django.forms.fields.Select is required

comment:3 by Michael Thornhill, 15 years ago

Has patch: set
Patch needs improvement: unset

Improved patch by removing unnecessary imports from forms.py and removed unnecessary country string from all counties

by Michael Thornhill, 15 years ago

Attachment: ie.tar.gz added

ie localflavor with County removed from all county names and unneccesary imports removed

comment:4 by anonymous, 15 years ago

milestone: 1.2

comment:5 by Russell Keith-Magee, 15 years ago

One quick question before I commit - Is there any sort of official abbreviation or enumeration that is (or could be) used for county names? (e.g., Australia uses "NSW" for New South Wales, "QLD" for Queensland, etc)

If no such abbreviation/enumeration exists, thats fine - Finnish municipalities are in the same category, for example. I just want to make sure that my ignorance of Irish municipal conventions doesn't lead to committing an enumeration where there might be a more efficient internal representation.

comment:6 by Michael Thornhill, 15 years ago

Hi Russell,
No such official abbreviation or enumeration exists for Irish County names.
Thanks
Michael

comment:7 by Jannis Leidel, 15 years ago

Resolution: fixed
Status: newclosed

(In [12043]) Fixed #11123 - Added Irish (ie) localflavor.

comment:8 by Jacob, 13 years ago

milestone: 1.2

Milestone 1.2 deleted

Note: See TracTickets for help on using tickets.
Back to Top