add a ModelAdmin.delete_model method, similar to ModelAdmin.save_model (+patch)

[thomas]

When we delete an object, it could be usefull to have the "request" attribute. For example to know "how is doing this delete", as shown as the exemple with save_model (​http://docs.djangoproject.com/en/1.0/ref/contrib/admin/#modeladmin-methods).

My very little patch creates a ModelAdmin.delete_model(self, request, obj) method, one can override in admin.py.

I use it in a custom log system, where I log all details of all modifications of a object, with the "modifier" who make the modification (request.user). I can log creations and modifications with save_model, now I can log delete() too.

Thanks.

[thomas]

patch to add ModelAdmin.delete_model() in contrib.admin.options.py

[shadfc]

from the trac-view of the patch above

 	1022	            self.delete_model(request, obj) 
1017	1023	 
1018	1024	            self.message_user(request, _('The %(name)s "%(obj)s" was deleted successfully.') %...

Slight bug -- if you don't actually delete the object, the message will still show. Similar bug with the delete log message?

[anonymous]

Replying to shadfc:

Slight bug -- if you don't actually delete the object, the message will still show. Similar bug with the delete log message?

not really imo, delete_model is expected to delete the object, so I guess this will fall under documentation (remember you confirmed that you really want to delete it already…)

[Florian Apolloner]

My testsuite is currently failing, but I guess that cause my settings.py isn't configured for multidb tests

[Sebastian Noack]

See also #13708

[Florian Apolloner]

Updated the patch to apply cleanly on current trunk, do we really need tests here? the delete functionality should already be covered by the view tests?

[Florian Apolloner]

New patch with tests for 'save_model' and 'delete_model'

[Alex Gaynor]

(In [14673]) Fixed #11108 -- added ModelAdmin.delete_model, a hook with which to perform custom pre-post delete behavior. Thanks to Florian Apolloner for the patch.

[Divad]

This should also include this change in actions.py:

47c47
<                 modeladmin.delete_model(request,obj)
---
>             queryset.delete()

To have the same result using delete_selected from actions.

[Julien Phalip]

Divad, you might want to open a new ticket if you'd like to make more changes. This ticket is closed, so your idea is likely to be forgotten if it stays here.

[Divad <david@…>]

Thanks julien, I will reopen.

[Florian Apolloner]

You should open a new ticket, not reopen old ones…

[Jacob]

Milestone 1.3 deleted