Opened 16 years ago

Closed 11 years ago

#11035 closed New feature (fixed)

urlify.js with Serbian alphabet

Reported by: Janoš Owned by: nobody
Component: contrib.admin Version: dev
Severity: Normal Keywords: slug slugify urlify
Cc: mmitar@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: yes Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Here is a patch for urilfy.js in admin application that should support Serbian alphabet. There are no collisions between existing and new mappings.

Attachments (2)

urlify.js.1.diff​ (326 bytes ) - added by Janoš 16 years ago.
urlify.diff​ (1.2 KB ) - added by Claude Paroz 14 years ago.
patch from #14345

Download all attachments as: .zip

Change History (13)

by Janoš, 16 years ago

Attachment: urlify.js.1.diff​ added

comment:1 by James Bennett, 16 years ago

milestone: 1.1

We're only accepting critical/blocker-type bugs for the 1.1 milestone.

comment:2 by Janoš, 16 years ago

There is a small discussion on ​http://groups.google.com/group/Django-I18N/browse_thread/thread/3eda74c88874ba32 about that patch. Recently the Serbian translation was changed to Cyrillic alphabet and this patch is related to that. Without urlify.js with mappings for Serbian language, the translation is not complete. Please consider this patch for 1.1 milestone. It is critical for complete suppor the Serbian i18n.

comment:3 by Alex Gaynor, 15 years ago

Triage Stage: Unreviewed → Accepted

comment:4 by Ramiro Morales, 14 years ago

#14345 is a duplicate and contains another patch for the issue.

comment:5 by oggy, 14 years ago

Ugh, late-night brain fart, forgot to check for duplicate issues. Thanks ramiro. This is essentially the same patch as mine, I don't mind either of them going in. Would one of the triagers consider marking this as ready for check-in?

by Claude Paroz, 14 years ago

Attachment: urlify.diff​ added

patch from #14345

comment:6 by Claude Paroz, 14 years ago

Easy pickings: unset
Severity: → Normal
Triage Stage: Accepted → Ready for checkin
Type: → Uncategorized

I don't think that js files are currently testable in Django.

comment:7 by Jannis Leidel, 14 years ago

Needs tests: set
Triage Stage: Ready for checkin → Accepted

Yet! We hope to land ​https://github.com/sebleier/django/tree/feature/q-unit soon.

comment:8 by Julien Phalip, 14 years ago

Type: Uncategorized → New feature

comment:9 by Julien Phalip, 13 years ago

UI/UX: unset

See related feature request in #8561.

comment:10 by Mitar, 13 years ago

Cc: mmitar@… added

I have added those translations to my improved JavaScript ​slug creation function which is using Unicode normalization too.

comment:11 by Baptiste Mispelon <bmispelon@…>, 11 years ago

Resolution: → fixed
Status: new → closed

In 20948612c79b936424cb12cf9988713708232ced:

Fixed issues and added new scripts to urlify.js

Added the following scripts:

  • Lithuanian (thanks to petraszd for the patch)
  • Serbian (thanks to offy)
  • Azerbajani (thanks to Ali Ismayilov)

Fixed the following issues:

  • In Polish character map, some uppercase letters were converted to a lowercase ascii equivalent.
  • The letter Y with a diaeresis had a lowercase version but no uppercase.

The code was also simplified and cleaned up:

  • Use of var statements everywhere
  • Systematic use of semicolons
  • Proper looping over arrays and objects.

Thanks to @oinopion for his help in getting the javascript
into proper shape.

Fixes #8561, #11035.

Note: See TracTickets for help on using tickets.
Back to Top