Opened 16 years ago
Closed 15 years ago
#10947 closed (fixed)
Queryset "__in" documentation missing list() call
| Reported by: | Julian Bez | Owned by: | nobody |
|---|---|---|---|
| Component: | Documentation | Version: | 1.0 |
| Severity: | Keywords: | ||
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
http://docs.djangoproject.com/en/dev/ref/models/querysets/#in
The part in "Performance considerations" does not work that way. It's missing a list() call to really get a list into the query.
Attachments (1)
Change History (5)
comment:1 by , 16 years ago
comment:2 by , 15 years ago
| Triage Stage: | Unreviewed → Accepted |
|---|
by , 15 years ago
| Attachment: | 10947.diff added |
|---|
comment:3 by , 15 years ago
| Has patch: | set |
|---|---|
| Triage Stage: | Accepted → Ready for checkin |
my fault, ticket is correct, patch attached.
comment:4 by , 15 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note:
See TracTickets
for help on using tickets.
As far as I can tell it is correct as is: values_list returns a list so calling list() on it would be redundant.