#1071 closed task (wontfix)
[patch] generic views (object_list/object_detail/date) should take login_required as a parameter
| Reported by: | Owned by: | Jacob | |
|---|---|---|---|
| Component: | Generic views | Version: | dev |
| Severity: | major | Keywords: | |
| Cc: | root.lastnode@… | Triage Stage: | Unreviewed |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
as some non-updated pages might require a login.
regards
Ian
Attachments (3)
Change History (11)
comment:1 by , 18 years ago
| Component: | Generic views → Database wrapper |
|---|---|
| milestone: | → Version 0.91 |
| Owner: | changed from to |
| priority: | normal → lowest |
| Severity: | normal → major |
| Type: | defect → task |
comment:2 by , 18 years ago
| Cc: | added |
|---|---|
| Summary: | generic views (object_list/object_detail/date) should take login_required as a parameter → [patch] generic views (object_list/object_detail/date) should take login_required as a parameter |
by , 18 years ago
| Attachment: | patch-django-views-generic_login-required_#1071 added |
|---|
comment:3 by , 18 years ago
| Component: | Database wrapper → Generic views |
|---|---|
| Owner: | changed from to |
isn't this part of 'generic views' component ?
sounds more likely to me, then 'database wrapper'
comment:4 by , 18 years ago
| milestone: | Version 0.91 → Version 0.92 |
|---|---|
| priority: | lowest → normal |
| Version: | → SVN |
by , 18 years ago
| Attachment: | patch-django-views-generic_login-required_#1071_2 added |
|---|
update to revision 3490
comment:5 by , 18 years ago
| priority: | normal → high |
|---|
set priority to: high
IMHO, it seems logical to get this patch in as soon as possible.
i know that there are several projects in django regarding a move
advanced authentication framework. But in neither GenericAuthorization
or RowLevelPermissions i find references on how this will change Authentication
of views.
As long as views deal directly with there own authentication, i hope this patch
can be adopted for completeness sake. So users can require login on all generic views
django provides per default.
When another system takes over, i guess all the login_required parameters will be stripped
from generic views, so including a few more now to deal with authentication on
list_detail and alike generic views doesn't seem like a problem to me.
Ofcourse i'll leave the definition of 'problem' to the Django developers :)
by , 18 years ago
| Attachment: | patch-django-views-generic_login-required_#1071_2.diff added |
|---|
update to revision 3490 now with .diff ending as recommended in contributing documentation
comment:6 by , 18 years ago
| priority: | high → low |
|---|
comment:7 by , 18 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
I'm marking this as a wontfix now, because as of [3554], URLconfs can take any callable. That means you can pass login_required(my_generic_view) directly to the URLconf.
i also wanted to project generic views like object_list/object_detail and alikes.
created a patch to the django.views.generic sources to allow login_required parameter
to be set on all but django.views.generic.simple generics
-- trbs