Opened 16 years ago

Closed 16 years ago

Last modified 13 years ago

#10643 closed (fixed)

formtools do not handle forms with empty_permitted

Reported by: Nils Fredrik Gjerull Owned by:
Component: contrib.formtools Version: dev
Severity: Keywords: empty_permitted
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

django.contrib.formtools do not handle forms with empty_permitted set to true correctly. It tries to validate the form data even if the form has not changed.

Attachments (5)

formtools_utils.diff​ (676 bytes ) - added by Nils Fredrik Gjerull 16 years ago.
10643.diff​ (1.7 KB ) - added by Andy Durdin 16 years ago.
Updated patch to add tests
10643.2.diff​ (1.7 KB ) - added by Andy Durdin 16 years ago.
Better names in patch
security_hash.diff​ (2.1 KB ) - added by Ulrich Petri 16 years ago.
Cleaned up testcase
security_hash.2.diff​ (2.1 KB ) - added by Ulrich Petri 16 years ago.
Fixed stupid diff-of-diff mistake

Download all attachments as: .zip

Change History (12)

by Nils Fredrik Gjerull, 16 years ago

Attachment: formtools_utils.diff​ added

comment:1 by Jacob, 16 years ago

milestone: → 1.1
Needs documentation: set
Needs tests: set
Patch needs improvement: set
Triage Stage: Unreviewed → Accepted

comment:2 by Andy Durdin, 16 years ago

Owner: changed from nobody to Andy Durdin
Status: new → assigned

comment:3 by Andy Durdin, 16 years ago

Needs documentation: unset
Needs tests: unset
Patch needs improvement: unset

Updated patch to add tests.

by Andy Durdin, 16 years ago

Attachment: 10643.diff​ added

Updated patch to add tests

comment:4 by Andy Durdin, 16 years ago

Owner: Andy Durdin removed
Status: assigned → new

comment:5 by Jacob, 16 years ago

A better name for the test case is all that's standing between this and committing.

by Andy Durdin, 16 years ago

Attachment: 10643.2.diff​ added

Better names in patch

by Ulrich Petri, 16 years ago

Attachment: security_hash.diff​ added

Cleaned up testcase

by Ulrich Petri, 16 years ago

Attachment: security_hash.2.diff​ added

Fixed stupid diff-of-diff mistake

comment:6 by Jacob, 16 years ago

Resolution: → fixed
Status: new → closed

(In [10753]) Fixed #10643: fixed the formtools security hash to handle allowed empty forms or forms without changed data.

comment:7 by Jacob, 13 years ago

milestone: 1.1

Milestone 1.1 deleted

Note: See TracTickets for help on using tickets.
Back to Top