Opened 19 years ago
Closed 19 years ago
#1062 closed defect (fixed)
[patch] typecast on date fails
| Reported by: | Owned by: | Adrian Holovaty | |
|---|---|---|---|
| Component: | Database layer (models, ORM) | Version: | dev |
| Severity: | normal | Keywords: | |
| Cc: | nesh@… | Triage Stage: | Unreviewed |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
When using date based generic views with SQLite, the following error occurrs:
Exception Type: ValueError
Exception Value: need more than 1 value to unpack
Exception Location: /usr/local/lib/python2.4/site-packages/django/core/db/typecasts.py in typecast_timestamp, line 22
It seems the typecast for date assumes date+time, whereas the DateField() comes back with only a date.
I have worked around this problem using the following patch:
--- typecasts.py 2005-10-21 11:11:48.000000000 +1000
+++ /usr/lib/python2.4/site-packages/Django-0.90-py2.4.egg/django/core/db/typecasts.py 2005-12-14 12:57:53.000000000 +1100
@@ -20,7 +20,11 @@
# "2005-07-29 15:48:00.590358-05"
# "2005-07-29 09:56:00-05"
if not s: return None
+ try:
d, t = s.split()
+ except ValueError:
+ d = s
+ t = '00:00:01'
# Extract timezone information, if it exists. Currently we just throw
# it away, but in the future we may make use of it.
if '-' in t:
Attachments (1)
Change History (5)
comment:1 by , 19 years ago
| Version: | → SVN |
|---|
comment:2 by , 19 years ago
| Cc: | added |
|---|
by , 19 years ago
| Attachment: | typecast.diff added |
|---|
comment:3 by , 19 years ago
| Summary: | typecast on date fails → [patch] typecast on date fails |
|---|
Another sollution is to not use DateField alltogether, use only DateTimeField which works OK.
comment:4 by , 19 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
slightly different patch