many files with the same file name cannot be saved correctly

[liangent]

The current Django code add '_' to file name in order to avoid overwrite saved files.
However, if I save many files with the same file name, Django will add many '_'s.
If the file name is too long, file will be saved correctly, but path in database will be truncated.

/var/lib/python-support/python2.5/django/db/backends/mysql/base.py:83: Warning: Data truncated for column 'output' at row 1
  return self.cursor.execute(query, args)

Then when I try to get that file according to the path saved in database, it will fail...

[(none)]

Milestone post-1.0 deleted

[Marcelo Ramos]

Is adding the creation timestamp to the filename a good solution for this?

[Marcelo Ramos]

I mean, that way multiple files with the same filename can be saved with different names keeping them short.

[Bob Thomas]

Timestamps could still be long. Appending a number to the end of a filename would be much better than more underscores, though.

Something like:

name
name_0
name_1
name_2
...etc

[ianschenck]

patch

[duncan]

Patch to the code looks fairly sensible to me. I think we could do with some more tests though.

[Andy Durdin]

Fixing this may affect the patch or tests for #9610

[Thilo]

Added one more doctest which uploads 10 files and checks for their names.

[Thilo]

#9610 indeed conflicts with this issue: both of the patches change the same lines in django/core/files/storage.py. I merged them locally and created a diff for 10258 which will apply on top of #9610. Attachment follows.

[Thilo]

Patch that applies when patch from #9610 has been applied before. Apart from that its identical to 10258.2.diff

[Jacob]

Punting to 1.2. For now, use a custom upload_to and/or override the storage engine's get_available_filename function.

[Jacob]

(In [12552]) Fixed #10258: handle duplicate file names better.

Instead of just continually appending "_" to duplicate file names, Django's
default storage now appends _1, _2, _3, etc.

Thanks to ianschenck and Thilo.

[Jacob]

Milestone 1.2 deleted