Opened 17 years ago
Last modified 13 years ago
#7250 closed
Internal data shown when uploading a ImageField fails — at Version 4
Reported by: | Marc Garcia | Owned by: | nobody |
---|---|---|---|
Component: | contrib.admin | Version: | newforms-admin |
Severity: | Keywords: | nfa nfa-someday | |
Cc: | marc.garcia@… | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | yes | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
In newforms-admin, when uploading a file that isn't an image to a ImageField field, file internal data is display for "Currently". Shown data is something like {'content': '', 'content-type': 'text/plain', 'filename': 'test.txt'
}
Same will happen if anything else fails when uploading to a FileField or a ImageField.
Change History (5)
comment:1 by , 17 years ago
Keywords: | nfa-someday added |
---|
comment:2 by , 17 years ago
Has patch: | set |
---|---|
Needs tests: | set |
Cannot add tests with the patch because the difficulty in testing with files on the python shell.
I've tested the patch in the admin, but testing on forms and with ModelForm is still required.
This patch isn't supposed to modify the behavior of file deletion, but it would be recommended to check it.
comment:3 by , 17 years ago
milestone: | → 1.0 |
---|
comment:4 by , 17 years ago
Description: | modified (diff) |
---|
Not pretty but not a deal-breaker for merge to trunk.