Changes between Initial Version and Version 1 of Ticket #36248, comment 2


Ignore:
Timestamp:
Mar 12, 2025, 1:03:58 AM (8 hours ago)
Author:
Simon Charette

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #36248, comment 2

    initial v1  
    1 The analysis and the patch here are on point (thanks bobince!) so I'll accept and mark with ''has_patch''.
     1The analysis and the patch here are on point (thanks bobince!) so I'll accept and mark with ''has patch''. Please turn it into an actual PR.
    22
    33The only thing I'd change is the test so `bulk_batch_size` is mocked to return a small number (e.g. 10) and not only test the number of executed queries but count the number of parameters for each queries (you can use `self.assertNumQueries` as a context manager for that).
Back to Top