Opened 2 days ago
Last modified 17 hours ago
#36038 assigned Cleanup/optimization
Added a test case for the display_for_field function when a FileField is passed. — at Initial Version
Reported by: | Antoliny | Owned by: | |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Normal | Keywords: | display_for_field, FileFIeld |
Cc: | Triage Stage: | Accepted | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
def display_for_field(value, field, empty_value_display): from django.contrib.admin.templatetags.admin_list import _boolean_icon ... elif isinstance(field, (models.IntegerField, models.FloatField)): return formats.number_format(value) elif isinstance(field, models.FileField) and value: return format_html('<a href="{}">{}</a>', value.url, value) ...
There is no test case for the display_for_field function when a FileField
object is passed. --> admin_utils test code
When the FileField
handling was added in the above function, I found that the test was conducted indirectly through the ModelAdmin readonly_fields attribute. --> test code
However, I believe it would be better to have a direct test case for when a FileField is passed, considering that display_for_field function is globally accessible.
Note:
See TracTickets
for help on using tickets.