Opened 6 days ago
Last modified 5 days ago
#36004 closed Cleanup/optimization
Fixing Icons: auto, sun, and moon — at Initial Version
| Reported by: | Pablo Bengoechea | Owned by: | |
|---|---|---|---|
| Component: | contrib.admin | Version: | dev |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Unreviewed | |
| Has patch: | no | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | yes |
Description
Regarding ticket #35829, which addresses the migration of icons from the Font-Awesome-SVG-PNG library to the main Font Awesome repository, the following has been identified:
The icons icon-sun, icon-moon, and icon-auto are not stored in the img folder within the directory contrib/admin/static/admin/img.
These icons are directly called from the django/contrib/admin/templates/admin/base.html file.
It is unclear which library these icons originate from, as I did not find them in the Font-Awesome-SVG-PNG library.
My proposal to address this issue is as follows:
Identify the original source of the icon-sun, icon-moon, and icon-auto icons in Font Awesome version 6.7.1, download these icons from this version in an appropriate format (SVG), and store them in the img folder within the directory contrib/admin/static/admin/img. Then, update the base.html file to reference these icons from the new location.
Finally, test the changes to ensure that the icons load correctly and retain their functionality in the relevant views. I am not sure if it would be best to combine this with ticket #35829