Test classes with @translation.override decorator are not run

[Arthur Pemberton]

For example, the test "CustomTimeInputFormatsTests" does not get discovered and ran via:
./runtests.py forms_tests.tests.test_input_formats

And attempting to run the test direct with ./runtests.py forms_tests.tests.test_input_formats.CustomTimeInputFormatsTests results in an error:

AttributeError: 'CustomTimeInputFormatsTests' object has no attribute 'runTest'. Did you mean: 'subTest'?

Using Python 3.12, I followed the steps from ​https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/unit-tests/#running-the-unit-tests to setup a clean environment.

[Arthur Pemberton]

From that module, the following tests are seemingly all affected:

• CustomTimeInputFormatsTests
• CustomDateInputFormatsTests
• CustomDateTimeInputFormatsTests

[Sarah Boyce]

Thank you - well spotted!
Looks like any test class with a class level @translation.override is affected (this includes tests.timezones.tests.TemplateTests and tests.timezones.tests.AdminTests)

[Arthur Pemberton]

I believe this bug is covering the existence of another bug: that TIME_INPUT_FORMATS is not used by forms.TimeField as one might expect -- and that in fact, CustomTimeInputFormatsTests, which tests this, should be failing.

Should I wait on this ticket before creating one about TIME_INPUT_FORMATS not working as expected? Or should I create another ticket in parallel?

[Jacob Walls]

I think separate tickets make sense.

[Simon Charette]

Tests appears to pass even with the timezone.override adjustments

tests/forms_tests/tests/test_input_formats.py

@@ -118 +118 @@
         self.assertEqual(text, "13:30:00")
 
 
-@translation.override(None)
 @override_settings(TIME_INPUT_FORMATS=["%I:%M:%S %p", "%I:%M %p"])
 class CustomTimeInputFormatsTests(SimpleTestCase):
+    @classmethod
+    def setUpClass(cls):
+        cls.enterClassContext(translation.override(None))
+        super().setUpClass()
+
     def test_timeField(self):
         "TimeFields can parse dates in the default format"
         f = forms.TimeField()
@@ -431 +435 @@
         self.assertEqual(text, "21.12.2010")
 
 
-@translation.override(None)
 @override_settings(DATE_INPUT_FORMATS=["%d.%m.%Y", "%d-%m-%Y"])
 class CustomDateInputFormatsTests(SimpleTestCase):
+    @classmethod
+    def setUpClass(cls):
+        cls.enterClassContext(translation.override(None))
+        super().setUpClass()
+
     def test_dateField(self):
         "DateFields can parse dates in the default format"
         f = forms.DateField()
@@ -752 +760 @@
         self.assertEqual(text, "21.12.2010 13:30:00")
 
 
-@translation.override(None)
 @override_settings(DATETIME_INPUT_FORMATS=["%I:%M:%S %p %d/%m/%Y", "%I:%M %p %d-%m-%Y"])
 class CustomDateTimeInputFormatsTests(SimpleTestCase):
+    @classmethod
+    def setUpClass(cls):
+        cls.enterClassContext(translation.override(None))
+        super().setUpClass()
+
     def test_dateTimeField(self):
         "DateTimeFields can parse dates in the default format"
         f = forms.DateTimeField()

tests/timezones/tests.py

@@ -921 +921 @@
                 self.assertEqual(obj.dt, dt)
 
 
-@translation.override(None)
 @override_settings(DATETIME_FORMAT="c", TIME_ZONE="Africa/Nairobi", USE_TZ=True)
 class TemplateTests(SimpleTestCase):
+    @classmethod
+    def setUpClass(cls):
+        cls.enterClassContext(translation.override(None))
+        super().setUpClass()
+
     @requires_tz_support
     def test_localtime_templatetag_and_filters(self):
         """
@@ -1324 +1328 @@
             self.assertIn("2011-09-01 17:20:30", str(form))
 
 
-@translation.override(None)
 @override_settings(
     DATETIME_FORMAT="c",
     TIME_ZONE="Africa/Nairobi",
@@ -1334 +1337 @@
 class AdminTests(TestCase):
     @classmethod
     def setUpTestData(cls):
+        cls.enterClassContext(translation.override(None))
         cls.u1 = User.objects.create_user(
             password="secret",
             last_login=datetime.datetime(2007, 5, 30, 13, 20, 10, tzinfo=UTC),
@@ -1403 +1407 @@
                 reverse("admin_tz:timezones_timestamp_change", args=(t.pk,))
             )
         self.assertContains(response, t.created.astimezone(ICT).isoformat())
+        self.assertContains(response, t.created.astimezone(ICT).isoformat())

[Jacob Walls]

For reference, this is the companion ticket that was closed: ticket:35990.

[Arthur Pemberton]

Correct. This seems to work as such by design.