Opened 5 months ago

Last modified 12 days ago

#35650 assigned New feature

Multi select checkboxes with shift key is not working in TabularInlineAdmin and StackedInlineAdmin

Reported by: tanaydin sirin Owned by: tanaydin sirin
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: yes

Description (last modified by tanaydin sirin)

On any object list, we can select multiple objects by pressing the shift key while clicking the second checkbox, but it's not possible with TabularInline and StackedInlineAdmin ModelAdmin.

Change History (17)

comment:1 by tanaydin sirin, 5 months ago

Has patch: set

​https://github.com/django/django/pull/18438

Last edited 5 months ago by tanaydin sirin (previous) (diff)

comment:2 by tanaydin sirin, 5 months ago

Version: 5.0 → 5.1

Fix at

​https://github.com/django/django/pull/18438

Version 0, edited 5 months ago by tanaydin sirin (next)

comment:3 by Natalia Bidart, 5 months ago

Patch needs improvement: set
Triage Stage: Unreviewed → Accepted
Version: 5.1 → dev

Hello tanaydin sirin, thank you for your interest in making Django better. I have reproduced the described issue, and I agree it would be good to allow for shift-selecting in tabular admins just like in the changelist page.

I took a quite look at your PR, and I was thinking that instead of providing new javascript, we should try to re-use/generalize what the changelist page is already using. Could you look into that?

comment:4 by Sarah Boyce, 5 months ago

Owner: set to tanaydin sirin
Status: new → assigned

in reply to:  3 comment:5 by tanaydin sirin, 4 months ago

Hello Natalia Bidart, I've made the changes. Shall I do anything else about ticket?

Replying to Natalia Bidart:

Hello tanaydin sirin, thank you for your interest in making Django better. I have reproduced the described issue, and I agree it would be good to allow for shift-selecting in tabular admins just like in the changelist page.

I took a quite look at your PR, and I was thinking that instead of providing new javascript, we should try to re-use/generalize what the changelist page is already using. Could you look into that?

comment:6 by tanaydin sirin, 4 months ago

Description: modified (diff)
Summary: Multi select checkboxes with shift key is not working in TabularInlineAdmin → Multi select checkboxes with shift key is not working in TabularInlineAdmin and StackedInlineAdmin

comment:7 by Natalia Bidart, 4 months ago

Thank you tanaydin sirin! The expected ticket update process is described in ​these docs. Basically you need to uncheck the "patch needs improvement" flag, and then this ticket will show up in the "needs review queue" in the ​Django Development Dashboard.

comment:8 by tanaydin sirin, 4 months ago

Patch needs improvement: unset

comment:9 by Sarah Boyce, 4 months ago

Needs tests: set
Patch needs improvement: set

comment:10 by tanaydin sirin, 4 weeks ago

Needs tests: unset
Patch needs improvement: unset
UI/UX: set

comment:11 by tanaydin sirin, 4 weeks ago

Description: modified (diff)
Summary: Multi select checkboxes with shift key is not working in TabularInlineAdmin and StackedInlineAdmin → Multi select checkboxes with shift key is not working in TabularInlineAdmin

comment:12 by tanaydin sirin, 4 weeks ago

Triage Stage: Accepted → Ready for checkin

comment:13 by Sarah Boyce, 4 weeks ago

Triage Stage: Ready for checkin → Accepted

You cannot mark your own contributions as "Ready for checkin".
This should be done by a community member after a review and approval. See ​https://docs.djangoproject.com/en/5.1/internals/contributing/triaging-tickets/#ready-for-checkin

comment:14 by tanaydin sirin, 4 weeks ago

Description: modified (diff)
Summary: Multi select checkboxes with shift key is not working in TabularInlineAdmin → Multi select checkboxes with shift key is not working in TabularInlineAdmin and StackedInlineAdmin

comment:15 by tanaydin sirin, 4 weeks ago

Patch needs improvement: set

comment:16 by tanaydin sirin, 4 weeks ago

Patch needs improvement: unset

comment:17 by Sarah Boyce, 12 days ago

Patch needs improvement: set

For others, these are the checkboxes that appear of the change page (these are not available on the add page)

Note: See TracTickets for help on using tickets.
Back to Top