Opened 9 months ago
Last modified 9 months ago
#35354 closed Cleanup/optimization
Simplify ASGIRequest path handling. — at Version 3
| Reported by: | Carlton Gibson | Owned by: | Carlton Gibson |
|---|---|---|---|
| Component: | HTTP handling | Version: | 5.0 |
| Severity: | Normal | Keywords: | asgi |
| Cc: | Andrew Godwin | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Following the ASGI HTTP Connection Scope docs[0], the provided path is already the correct value that Django requires.
In combination with root_path, from which script_name is derived, the path_info variable is set.
It's then redundant to re-calculate path from script_name and path_info.
See also, a clarifying discussion on the ASGIref repo[1].
[0]: https://asgi.readthedocs.io/en/latest/specs/www.html#http-connection-scope
[1]: https://github.com/django/asgiref/issues/424
Change History (3)
comment:1 by , 9 months ago
| Owner: | changed from to |
|---|
comment:2 by , 9 months ago
| Cc: | added |
|---|
comment:3 by , 9 months ago
| Description: | modified (diff) |
|---|
Note:
See TracTickets
for help on using tickets.
PR