Add link for admin's related widget is in the wrong place

[Tom Carrick]

​PR

[Tom Carrick]

Regression in ​1699f8b52ac15f687cc39088401c2641022c71cd.

So I think this is a release blocker for 5.0, not 4.2?

[Natalia Bidart]

Agreed, this is a 5.0 release blocker.

[Natalia Bidart]

Getting a selenium failure that needs debugging.

[Mariusz Felisiak]

IMO we shouldn't treat this as a release blocker. "+" always had various issues, you can play with font and screen sizes and you'll notice various incorrect behaviors in the older versions of Django. I don't believe that Django 5.0 made it significantly worse. Also, there is a huge risk that the proposed patch will introduce further regressions. Let's don't backport it.

[Mariusz Felisiak]

Replying to Mariusz Felisiak:

IMO we shouldn't treat this as a release blocker. "+" always had various issues, you can play with font and screen sizes and you'll notice various incorrect behaviors in the older versions of Django. I don't believe that Django 5.0 made it significantly worse. Also, there is a huge risk that the proposed patch will introduce further regressions. Let's don't backport it.

I leave the final decision to Natalia, I'm not going to die on this hill.

[Tom Carrick]

Personally, I don't think this needs to be in 4.2.x. However, I would like to see it in 5.0. I promise to fix any regressions!

[Natalia <124304+nessita@…>]

In af2fd36:

Refs #34995 -- Made Selenium tests more robust for admin_views and admin_widgets suites.

Depending on screen sizes, the selenium tests that would "click" or interact
with an element outside the scope of the visible window would produce test
failures (raising ElementNotInteractableException in CI runs).

This branch switches those to using ActionChains, which ensures that the click
(or other interaction) is performed only after successfully completing the
move to the relevant element.

Co-authored-by: Tom Carrick <tom@…>

[Natalia <124304+nessita@…>]

In 999ba9d:

Fixed #34995 -- Improved position of related widget's add link on admin pages on small screens.

Regression in 1699f8b52ac15f687cc39088401c2641022c71cd.

Co-authored-by: Sarah Boyce <42296566+sarahboyce@…>
Co-authored-by: Natalia Bidart <124304+nessita@…>

[Natalia Bidart]

I have merged the PR #17517 in main and will review how a potential backport would look like in stable/5.0x. Then I'll report back on next steps. Thanks everyone!

[Natalia Bidart]

I have locally backported and tested 999ba9db6d6331eaa58af77debba42754bcc1a8e in stable/5.0.x and I haven't find any (new) Admin UI issues, only improvements. I have tested small (phone), medium (tablet) and wide (desktop) screens, both horizontal and vertical rotated viewports, light and dark modes, and LTR and RTL languages.
I'm a bit dizzy at this point but I'm fairly confident that with this change, the "green plus sign" is consistently shown to the right of the M2M selector (in LTR langs, it's shown to the left in RTL langs) and I think this is an improvement over what's currently available.

Given the above, and given Tom's explicit commitment to fix any potential regression, I think this is a good change to be included in 5.0. I'll be backporting the mentioned revision and the previous one that make some Selenium tests more robust.

[Natalia <124304+nessita@…>]

In 9fe12b0:

[5.0.x] Refs #34995 -- Made Selenium tests more robust for admin_views and admin_widgets suites.

Depending on screen sizes, the selenium tests that would "click" or interact
with an element outside the scope of the visible window would produce test
failures (raising ElementNotInteractableException in CI runs).

This branch switches those to using ActionChains, which ensures that the click
(or other interaction) is performed only after successfully completing the
move to the relevant element.

Co-authored-by: Tom Carrick <tom@…>

Backport of af2fd368156439b79e4c1eb2278c433246771e44 from main

[Natalia <124304+nessita@…>]

In 471fa926:

[5.0.x] Fixed #34995 -- Improved position of related widget's add link on admin pages on small screens.

Regression in 1699f8b52ac15f687cc39088401c2641022c71cd.

Co-authored-by: Sarah Boyce <42296566+sarahboyce@…>
Co-authored-by: Natalia Bidart <124304+nessita@…>

Backport of 999ba9db6d6331eaa58af77debba42754bcc1a8e from main