Opened 3 years ago
Last modified 2 years ago
#33750 closed Cleanup/optimization
Use <div> for timezone warning in admin — at Version 1
| Reported by: | Florian Demmer | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | 4.0 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | yes |
Description (last modified by )
Previously help_text was inserted as <p> in admin. This was changed in #27207 to use a <div>.
The addTimezoneWarning() function has "always" added the warning by inserting a <br> and <span>.
Also using a <div> with the help class here avoids problems with left-alignment of the inserted text (see attachment) and removes the need for the <br>.
Note:
See TracTickets
for help on using tickets.