Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#33432 closed Bug (fixed)

Missing comma in 'How to create CSV output'

Reported by: Zeilentaucher Owned by: Zeilentaucher
Component: Documentation Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

In the documentation, is a comma missing in the argument list

File: docs/howto/outputting-csv.txt

Is:

        response = HttpResponse(
            content_type='text/csv'
            headers={'Content-Disposition': 'attachment; filename="somefilename.csv"'},
        )

should be:

        response = HttpResponse(
            content_type='text/csv',
            headers={'Content-Disposition': 'attachment; filename="somefilename.csv"'},
        )

Change History (4)

comment:1 by Mariusz Felisiak, 3 years ago

Triage Stage: Unreviewed → Accepted

Thanks for the report. Would you like to prepare a patch?

PS. For the future, no ticket is required for typos.

comment:2 by Zeilentaucher, 3 years ago

Has patch: set
Owner: changed from nobody to Zeilentaucher
Status: new → assigned
Version: 4.0 → dev
Version 0, edited 3 years ago by Zeilentaucher (next)

comment:3 by GitHub <noreply@…>, 3 years ago

Resolution: → fixed
Status: assigned → closed

In 658dc704:

Fixed #33432 -- Fixed typo in docs/howto/outputting-csv.txt.

comment:4 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

In 89d8841:

[4.0.x] Fixed #33432 -- Fixed typo in docs/howto/outputting-csv.txt.

Backport of 658dc7045aaba548f908bb26a370eb89fb393bca from main

Note: See TracTickets for help on using tickets.
Back to Top