Changes between Initial Version and Version 1 of Ticket #30475, comment 6


Ignore:
Timestamp:
Jun 6, 2019, 3:20:48 AM (6 years ago)
Author:
Carlton Gibson

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30475, comment 6

    initial v1  
    99Ultimately here I think it's up to the user to ensure their 404 template loads correctly. That's straight-forward to test. **If** they do introduce an error, yes we drop right through to the very bottom `handle_uncaught_exception()` but we know something bad has happened in that case. As Mariusz points you to, `DEBUG_PROPAGATE_EXCEPTIONS` reveals the issue immediately.
    1010
    11 A custom 404 handler adding logging and/or exception handling around the `get_template()` call would be possible. But it's unnecessary overhead: a simple test that the 404.html template does in fact load makes this unnecessary.
     11A custom 404 handler adding logging and/or exception handling around the `get_template()` call would be possible. But it's unnecessary overhead: a simple test that the 404.html template does in fact load makes this redundant.
    1212
    1313Sorry if that's not what you want to hear.
Back to Top