Changes between Version 1 and Version 2 of Ticket #29724, comment 14


Ignore:
Timestamp:
Sep 5, 2019, 2:36:40 PM (5 years ago)
Author:
yab

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #29724, comment 14

    v1 v2  
    1 Hello Carlton,
    2 Here is my pull request (happy, it is my first and only one!):
    3 [https://github.com/django/django/pull/11747]
    4 It now passes the test cases written by ahbk in PR ticket_29724 [https://github.com/ahbk/django/tree/ticket_29724], called test_date_hierarchy_local_date_differ_from_utc and test_choice_links_date.
    5 No doubt it should be better coded as this code repeats itself... But it is a simple way to make aware date_hierarchy work with TZs.
    6 
    7 Replying to [comment:13 Carlton Gibson]:
    8 > yab: please make a pull request with your suggested changes. (See the [https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#patch-style contributing guide].)
    9 >
    10 > For tests, please **add** a test case with the example(s) here. Presumably they should fail with the exisiting code, showing the bug, and then pass with your patch applied.
Back to Top