Changes between Initial Version and Version 1 of Ticket #29570, comment 3


Ignore:
Timestamp:
Jul 18, 2018, 11:54:07 PM (6 years ago)
Author:
Alejandro Dubrovsky

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #29570, comment 3

    initial v1  
    1 Done: https://github.com/django/django/pull/10196
     1Done (update): https://github.com/django/django/pull/10201
    22
    33As mentioned in the pull request, the check only runs when staticfiles takes over (ie in DEBUG mode when staticfiles is in the INSTALLED_APPS), since that is when the problem occurs and that's what the warning warns about.
    44
     5Also, I've fixed the isort failure and most of the flake8 failure but the two remaining are  'E128 continuation line under-indented for visual indent' which seems to be due to the recommended style by Django, and the related 'E125 continuation line with same indent as next logical line'.
     6
     7Could someone look at that bit of code and tell me which format would be acceptable for the project please?
     8ie
     9
     10{{{
     11    with self.assertWarnsMessage(UserWarning,
     12            'The contrib.staticfiles app will not serve media if MEDIA_URL is within STATIC_URL'):
     13}}}
Back to Top