Document and test Field.empty_value for CharField subclasses
Hi folks, question: Do the changes made in #4136 also impact models.CharField subclasses (CommaSeparatedIntegerField, EmailField, SlugField, and URLField) and forms.CharField subclasses (RegexField, EmailField, URLField, GenericIPAddressField, SlugField, and UUIDField)? Based on my review of the code they do, though I may be missing something. If they are, the docstrings and documentation for each of the forms.CharField subclasses should be updated. Additionally, the release notes should mention the other fields impacted. I'm happy to make a PR, if this is the case.
Change History
(10)
| Summary: |
Changes to models.CharField and forms.CharField impact subclasses as well → Document and test Field.empty_value for CharField subclasses
|
| Triage Stage: |
Unreviewed → Accepted
|
| Owner: |
Matt Braymer-Hayes removed
|
| Status: |
assigned → new
|
| Has patch: |
set
|
| Owner: |
set to David Smith
|
| Patch needs improvement: |
set
|
| Patch needs improvement: |
unset
|
| Status: |
new → assigned
|
| Triage Stage: |
Accepted → Ready for checkin
|
| Resolution: |
→ fixed
|
| Status: |
assigned → closed
|
Looking at the source code (https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L2237) shows that the new CharField behavior is the same for other fields inheriting from it.