Opened 15 years ago

Closed 9 years ago

#13146 closed New feature (wontfix)

Remove hardcoded stuff in contrib.admin

Reported by: utku Owned by: utku
Component: contrib.admin Version: 1.1
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

There're lots of unnecessary hardcoded elements with the Admin which makes it hard to customize. Some examples:

​http://code.djangoproject.com/browser/django/trunk/django/contrib/admin/widgets.py#L126 (hardcoded image)
​http://code.djangoproject.com/browser/django/trunk/django/contrib/admin/widgets.py#L95 (template/widget instead)
​http://code.djangoproject.com/browser/django/trunk/django/contrib/admin/options.py#L650 (move to template)
​http://code.djangoproject.com/browser/django/trunk/django/contrib/admin/widgets.py#L238 (hardcoded image, including width and height, this should go to CSS)

IMO, getting rid of almost all hardcoded elements is the base for a more extensible, customizable and easier to change/adapt interface (PK).

Change History (11)

comment:1 by Russell Keith-Magee, 15 years ago

Component: django.contrib.admin → User Experience
Triage Stage: Unreviewed → Accepted

comment:2 by Eric Holscher, 14 years ago

milestone: → 1.3

Seems easy enough to fix and make people's lives easier.

comment:3 by Julien Phalip, 14 years ago

milestone: 1.3

This is a fine idea, but without a patch this has no chance to make it in 1.3. Also, the line numbers in your description are probably outdated. It'd be useful if you could provide more ​details about those hardcoded things you're actually referencing.

Version 1, edited 10 years ago by johnhomes (previous) (next) (diff)

comment:4 by Luke Plant, 14 years ago

Type: → New feature

comment:5 by Luke Plant, 14 years ago

Severity: → Normal

comment:6 by Julien Phalip, 14 years ago

UI/UX: set

comment:7 by Julien Phalip, 14 years ago

Component: User Experience → contrib.admin

comment:8 by Aymeric Augustin, 13 years ago

UI/UX: unset

Change UI/UX from NULL to False.

comment:9 by Aymeric Augustin, 13 years ago

Easy pickings: unset

Change Easy pickings from NULL to False.

comment:10 by Aymeric Augustin, 13 years ago

UI/UX: set

Revert accidental batch modification.

comment:11 by Claude Paroz, 9 years ago

Resolution: → wontfix
Status: new → closed

The admin has been recently refactored with a new design. IMHO this ticket is nowadays unfortunately no longer actionable. Feel free to open new tickets with more descriptive stuff.

Note: See TracTickets for help on using tickets.
Back to Top