Opened 16 years ago

Last modified 13 years ago

#7957 closed

Chaining Queryset.extra() methods that contain parameters breaks the query — at Version 3

Reported by: Matthijs Owned by: Matthijs
Component: Database layer (models, ORM) Version: dev
Severity: Keywords: queryset extra select select_params
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Malcolm Tredinnick)

To reproduce:

Precondition a user 'root' exists with id=1

from django.contrib.auth.models import User
for result in User.objects.extra(select=
        {'foo3': "SELECT COUNT(auth_user.id) FROM auth_user WHERE (auth_user.username = %s)"}
        , select_params=['root']).extra(select=
        {'foo2': "SELECT COUNT(auth_user.id) FROM auth_user WHERE (auth_user.id = %s)"}
        , select_params=['1']):
    print result.foo3
# output should be:
# 1
# 1
for result in User.objects.extra(select=
        {'foo1': "SELECT COUNT(auth_user.id) FROM auth_user WHERE (auth_user.username = %s)"}
        , select_params=['root']).extra(select=
        {'foo2': "SELECT COUNT(auth_user.id) FROM auth_user WHERE (auth_user.id = %s)"}
        , select_params=['1']):
    print result.foo1
# output should be:
# 1
# 1

Change History (5)

by Matthijs, 16 years ago

Attachment: django_extra.diff​ added

patch to fix extra().extra() problem

by Matthijs, 16 years ago

Attachment: reproduce_extra_problem.py​ added

file that demonstrated bug

comment:1 by Matthijs, 16 years ago

Resolution: → fixed
Status: new → closed

comment:2 by Matthijs, 16 years ago

Resolution: fixed
Status: closed → reopened

comment:3 by Malcolm Tredinnick, 16 years ago

Description: modified (diff)
milestone: 1.0 beta → 1.0
Triage Stage: Unreviewed → Accepted

The patch looks like it's along the right lines, although I don't really like adding an append() method to the sorted dictionary. That's a bit of API creep that we can probably avoid.

Fixed milestone and description.

Note: See TracTickets for help on using tickets.
Back to Top