Opened 16 years ago

Last modified 13 years ago

#7244 closed

ModelChoicesField.__init__ and ModelMultipleChoicesField.__init__ must not pass a widget to the parent __init__. — at Version 4

Reported by: Sebastian Noack Owned by: Adrian Holovaty
Component: Forms Version: dev
Severity: Keywords: aug22sprint
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Ramiro Morales)

There is a bug in the ModelChoicesField and ModelMultipleChoicesField from django.newforms.models, which passed Select or MultipleSelect as default widget to the parent __init__ if not specified. This breaks the ability to set the widget class attribute in derived classes. I wrote a patch, that fixes this.

Change History (6)

by Sebastian Noack, 16 years ago

Attachment: 0001-Fixed-widget-handling-in-ModelChoicesField.__init__.patch​ added

comment:1 by Sebastian Noack, 16 years ago

Cc: Adrian Holovaty added

comment:2 by Sebastian Noack, 16 years ago

Cc: Adrian Holovaty removed
Owner: changed from nobody to Adrian Holovaty

by Sebastian Noack, 16 years ago

Attachment: 0001-Fixed-widget-handling-in-ModelChoicesField.__init__.2.patch​ added

comment:4 by Ramiro Morales, 16 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top