DecimalField tests with locale

[Dirk Datzert <dummy@…>]

I ran into an python locale issue with the DecimalField. During INSERTs and UPDATEs invalid sql-statements are generated since a comma-seperator ',' is used for formating DecimalField instead of the expected dot-seperator '.'

decimal-python.py (for simple testing):

from django.db.models.fields import DecimalField
from locale import setlocale, LC_NUMERIC
d = DecimalField(max_digits=6, decimal_places=3)
setlocale(LC_NUMERIC,'de_DE')
print d.format_number(3.456)
setlocale(LC_NUMERIC,'en_US')
print d.format_number(3.456)

---

linux-f426d:/home/admin/django/projects # export DJANGO_SETTINGS_MODULE=ais.settings
linux-f426d:/home/admin/django/projects # python decimal-python.py              
3,456
3.456

Environment:

• Django-SVN
• SuSE Linux Enterprise Server 10
• Python 2.4.2

On my private notebook this is no issue both outputs will be

3.456
3.456

Private Environment:

• Django-SVN
• OpenSuSe 10.3
• Python 2.5.1

[Dirk Datzert <dummy@…>]

short work-around for DecimalField format problems in db_prep methods

[Dirk Datzert <dummy@…>]

short work-around for DecimalField format problems in db_prep methods

[Philippe Raoult]

base tests for the issue

[Philippe Raoult]

my test machine doesn't have the appropriate locales but I'll run the tests tomorrow.

[Philippe Raoult]

slightly better tests

[Philippe Raoult]

The tests all pass with sqlite and mysql. I tried with both python 2.4.4 and 2.5.1. I'm marking ready for checking so we can commit the regression tests and hopefully get those run with other backends/versions.

Please note that the tests need the 'fr_FR' locale to run. If it's not available the test will be omitted (no failure though). If anyone has a more elegant solution I'd be happy to update the patch :)

[Malcolm Tredinnick]

Two problems here:

1. On a triage level, the test changes should have been part of the main patch. It took a while to realise that this "ready for checkin" thing was actually the second and the fourth patch.
2. More importantly, the solution isn't correct. setlocale() cannot be used in multi-threaded programs, since it changes the global locale, so it will affect the operation of other threads.

[yazzgoth]

I'm sorry to hijack this ticket.

I've uploaded a simple_patch.diff that should is a quick and dirty way of sorting this out.