Opened 17 years ago

Last modified 16 years ago

#6322 closed

ifchanged doesn't properly reset itself if not evaluated each time through the loop — at Initial Version

Reported by: Ned Batchelder Owned by: nobody
Component: Template system Version: dev
Severity: Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

When using ifchanged in a doubly-nested loop, the value is only reset to None on the inner loop's first iteration. But if the ifchanged tag is inside another conditional, it may not be evaluated on the first iteration. This can mean the value isn't properly reset:

{% for data in datalist %}

{% for c,d in data %}

{% if c %}

{% ifchanged %}{{ d }}{% endifchanged %}

{% endif %}

{% endfor %}

{% endfor %}

The fix is to not examine forloop.first explicitly, but to annotate the forloop context.

Change History (1)

by Ned Batchelder, 17 years ago

Attachment: ifchanged.diff added

the patch!

Note: See TracTickets for help on using tickets.
Back to Top