Changes between Version 1 and Version 2 of Ticket #35890, comment 6
- Timestamp:
- Nov 13, 2024, 9:20:42 AM (2 days ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #35890, comment 6
v1 v2 6 6 In your particular case, `Child.save(update_fields={...})`, won't update `"modified_at"` unless it's specified explicitly so your expectations are already broken for any direct or indirect (through third-party apps) usage of `save(update_fields)`; `update_or_create` is only a single instance of that. 7 7 8 The changes made to handle local concrete fields in #32095 ([https://github.com/django/django/pull/13526 original PR by Florian], [https://github.com/django/django/pull/16072 eventually merged changes by Sarah]) unfortunately it didn't cover this use case, [https://github.com/django/django/pull/13526#discussion_r503304168 even if it was pointed out as a point of ambiguity], as neither `Book` or `Publisher` are using MTI. Not to do any finger pointing here, I should have caught in the follow up PR and be more explicit about what I actually meant. I just wanted to point out that it was at least discussed at the time.8 The changes made to handle local concrete fields in #32095 ([https://github.com/django/django/pull/13526 original PR by Florian], [https://github.com/django/django/pull/16072 eventually merged changes by Sarah]) unfortunately didn't cover this use case as [https://github.com/django/django/pull/13526#discussion_r503304956 it wasn't pointed out clearly enough as a point of ambiguity]. 9 9 10 10 > Why do you think it should be that way? 11 11 12 From my perspective, given the intent #32095 was to avoid unnecessary field updates, performing MTI inherited tables updates when non of their fields are explicitly requested to be updated because the yuse a pattern meant to be deprecated is not the right approach.12 From my perspective, given the intent #32095 was to avoid unnecessary field updates, performing MTI inherited tables updates when non of their fields are explicitly requested to be updated because their respective table happen to use a pattern meant to be deprecated is not the right approach.