Changes between Initial Version and Version 1 of Ticket #35890, comment 6


Ignore:
Timestamp:
Nov 13, 2024, 9:15:52 AM (2 days ago)
Author:
Simon Charette

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #35890, comment 6

    initial v1  
    66In your particular case, `Child.save(update_fields={...})`, won't update `"modified_at"` unless it's specified explicitly so your expectations are already broken for any direct or indirect (through third-party apps) usage of `save(update_fields)`; `update_or_create` is only a single instance of that.
    77
    8 The changes made to handle local concrete fields in #32095 ([https://github.com/django/django/pull/13526 original PR by Florian], [https://github.com/django/django/pull/16072 eventually merged changes by Sarah]) unfortunately it didn't cover this use case, [https://github.com/django/django/pull/13526#discussion_r503304168 even if it was pointed out as a point of ambiguity], as neither `Book` or `Publisher` are using MTI.
     8The changes made to handle local concrete fields in #32095 ([https://github.com/django/django/pull/13526 original PR by Florian], [https://github.com/django/django/pull/16072 eventually merged changes by Sarah]) unfortunately it didn't cover this use case, [https://github.com/django/django/pull/13526#discussion_r503304168 even if it was pointed out as a point of ambiguity], as neither `Book` or `Publisher` are using MTI. Not to do any finger pointing here, I should have caught in the follow up PR and be more explicit about what I actually meant. I just wanted to point out that it was at least discussed at the time.
    99
    1010> Why do you think it should be that way?
Back to Top