Changes between Version 1 and Version 5 of Ticket #35382


Ignore:
Timestamp:
Apr 19, 2024, 9:35:01 AM (7 months ago)
Author:
Natalia Bidart
Comment:

During a ​Discord conversation between Sarah and Ben, they realized that this low-contrast issue was only reproducible in the context of a PR fixing #35189, meaning that the issue is not present in main. So we are re-purposing this ticket to confirm and delete the unused CSS style .inline-related fieldset.module h3.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #35382

    • Property Component Uncategorized → contrib.admin
    • Property Triage Stage Unreviewed → Accepted
    • Property Type Uncategorized → Bug
    • Property Summary Low contrast background color for fieldset headings within inline formsets → Remove unused CSS style `.inline-related fieldset.module h3`

  • Ticket #35382 – Description

    v1 v5  
    1 `.inline-related fieldset.module h3` has a background color of `#bcd` and text color of `#fff`
    2 This is hard to read and fails WCAG AA and WCAG AAA (this can be tested here [https://webaim.org/resources/contrastchecker/])
    3 
    4 Under Child: #1 and above Fields, see "Name" with the poor contrast
    5 [[Image(Color.png)]]
     1Currently, the CSS definition in `forms.css` for `.inline-related fieldset.module h3` (which is at least 16 years old) is not being used in the Django code base. The only templates using the `inline-related` CSS class are contrib/admin/templates/admin/edit_inline/tabular.html and contrib/admin/templates/admin/edit_inline/stacked.html, and the former only uses `h3` elements inside a `div` element which does not fulfill the CSS rule, and in the latter there is no usage of `h3` at all.
Back to Top