Changes between Initial Version and Version 1 of Ticket #35076


Ignore:
Timestamp:
Dec 31, 2023, 8:41:26 AM (11 months ago)
Author:
Mariusz Felisiak
Comment:

Thanks for the ticket, however, the current wording is clear enough (IMO).

If True (the default), the object’s get_absolute_url() method will be used to generate the url.

It clearly indicates that it won't do anything if you model doesn't have a get_absolute_url(). It's also followed by a sentence when it's explicitly stated:

If your model has a get_absolute_url() method but you don’t want the “View on site” button to appear, you only need to set view_on_site to False:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #35076

    • Property Resolution → invalid
    • Property Status new → closed

  • Ticket #35076 – Description

    initial v1  
    1 Whether get_absolute_url() is defined determines the visible state of  the “View on site” button, I suggest to change [the doc](https://docs.djangoproject.com/en/4.2/ref/contrib/admin/#django.contrib.admin.ModelAdmin.view_on_site) to the following to emphasize this(Note I have read the official doc on contributing to the doc, but it is hard for me to do that, so I posted my suggestion here ).
     1Whether get_absolute_url() is defined determines the visible state of  the “View on site” button, I suggest to change [https://docs.djangoproject.com/en/4.2/ref/contrib/admin/#django.contrib.admin.ModelAdmin.view_on_site the doc] to the following to emphasize this(Note I have read the official doc on contributing to the doc, but it is hard for me to do that, so I posted my suggestion here ).
    22
    33
    4 If the object’s  [`get_absolute_url()`](https://docs.djangoproject.com/en/4.2/ref/models/instances/#django.db.models.Model.get_absolute_url "django.db.models.Model.get_absolute_url")  method is defined, then  set `view_on_site`  to control whether or not to display the “View on site” link. This link should bring you to a URL where you can display the saved object. Otherwise, no effect.
     4If the object’s  [https://docs.djangoproject.com/en/4.2/ref/models/instances/#django.db.models.Model.get_absolute_url "django.db.models.Model.get_absolute_url" get_absolute_url()]  method is defined, then  set `view_on_site`  to control whether or not to display the “View on site” link. This link should bring you to a URL where you can display the saved object. Otherwise, no effect.
    55
    6 This value can be either a boolean flag or a callable. If  `True`  (the default), the object’s  [`get_absolute_url()`](https://docs.djangoproject.com/en/4.2/ref/models/instances/#django.db.models.Model.get_absolute_url "django.db.models.Model.get_absolute_url")  method will be used to generate the url.
     6This value can be either a boolean flag or a callable. If  `True`  (the default), the object’s  [https://docs.djangoproject.com/en/4.2/ref/models/instances/#django.db.models.Model.get_absolute_url get_absolute_url()]("django.db.models.Model.get_absolute_url")  method will be used to generate the url.
    77
Back to Top