BaseFormSet should use Form's default_renderer before defaulting to get_default_renderer().

[Christophe Henry]

When creating a BaseFormSet using a subclass Form that defines default_renderer to a custom, it's a bit disturbing that the BaseFormSet does not try to use this renderer before defaulting to get_default_renderer(). This requires the user to always explicitely specify the renderer when subclassing BaseFormSet or using formset_factory, which is error prone.

I propose the following: when instanciating a BaseFormSet, if self.renderer is None, instanciate an empty form with self.empty_form (the form's default_renderer may be a property) to get the form's default_renderer. If this one is None, default to get_default_renderer().

[Mariusz Felisiak]

Thanks for the report, however, this was discussed and rejected when we were working on #34532, check out ​comment.

[Christophe Henry]

Ok. Thank you for the information. I now realize that I tried to fix something that was already fixed in Django 5.0. Would it be possible to backport ​this fix (95e4d6b) to Django 4.2? Do I need to open a new ticket for this?

[Mariusz Felisiak]

Replying to Christophe Henry:

[]Ok. Thank you for the information. I now realize that I tried to fix something that was already fixed in Django 5.0. Would it be possible to backport ​this fix (95e4d6b) to Django 4.2? Do I need to open a new ticket for this?[]

Django 4.2 is in extended support and it doesn't receive bugfixes anymore (except security patches).