Opened 16 months ago
Last modified 16 months ago
#34720 closed Bug
BaseReloader.watch_dir() incorrectly checks for existence of path — at Version 2
Reported by: | Josh Thomas | Owned by: | nobody |
---|---|---|---|
Component: | Utilities | Version: | 4.2 |
Severity: | Normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
Within the watch_dir
method in django.utils.autoreload.BaseReloader
, the path is checked by calling on the absolute
method on the Path
object:
def watch_dir(self, path, glob): path = Path(path) try: path = path.absolute() except FileNotFoundError: logger.debug( "Unable to watch directory %s as it cannot be resolved.", path, exc_info=True, ) return logger.debug("Watching dir %s with glob %s.", path, glob) self.directory_globs[path].add(glob)
Except absolute
doesn't raise, it just returns the absolute path. Should be changed to an if check on path.exists()
:
Python 3.11.4 (main, Jul 17 2023, 15:40:49) [GCC 9.4.0] Type 'copyright', 'credits' or 'license' for more information IPython 8.14.0 -- An enhanced Interactive Python. Type '?' for help. In [1]: from pathlib import Path In [2]: Path('/home/josh/projects/django/nonexistent').absolute() Out[2]: PosixPath('/home/josh/projects/django/nonexistent') In [3]: Path('/home/josh/projects/django/nonexistent').exists() Out[3]: False
Willing to prepare a patch. I'm not sure of the etiquette behind self-assigning a ticket before it's been reviewed, so I'm just leaving it unassigned for now.
Change History (2)
comment:1 by , 16 months ago
Summary: | Path checking in BaseReloader.watch_dir() incorrectly checks for existence of path → BaseReloader.watch_dir() incorrectly checks for existence of path |
---|
comment:2 by , 16 months ago
Description: | modified (diff) |
---|
Note:
See TracTickets
for help on using tickets.