Changes between Initial Version and Version 1 of Ticket #34496


Ignore:
Timestamp:
Apr 14, 2023, 7:40:00 AM (19 months ago)
Author:
Hielke Walinga
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #34496 – Description

    initial v1  
    7373
    7474For whatever change you prefer, I can make a PR. Thank you. I hope the fix can also be applied in 4.2.
     75
     76== Post Scriptum
     77
     78I noticed, for complete backwards compatibility prior to named patterns, the template should also have a fallback for this.
     79
     80Current:
     81{{{
     82            matches["url"] = unquote(transformed_url)
     83            return template % matches
     84}}}
     85
     86Proposed change:
     87{{{
     88            try:
     89                  # Remain backwards compatible prior to changing to named template strings
     90                  return template % unquote(transformed_url)
     91            except TypeError:
     92                  # Template string is thus a named template string
     93                  return template % {"url": unquote(transformed_url)}
     94}}}
Back to Top