Opened 20 months ago

Last modified 20 months ago

#34317 closed Cleanup/optimization

wrong attribute naming in method BaseModelFormSet.save_existing — at Version 1

Reported by: Maxim Danilov Owned by: nobody
Component: Forms Version: dev
Severity: Normal Keywords: Formset, ModelFomset
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Maxim Danilov)

django.forms.models.py rows 654-667

we have a three methods:

    def save_new(self, form, commit=True):
        """Save and return a new model instance for the given form."""
        return form.save(commit=commit)

    def save_existing(self, form, instance, commit=True):
        """Save and return an existing model instance for the given form."""
        return form.save(commit=commit)

    def delete_existing(self, obj, commit=True):
        """Deletes an existing model instance."""
        if commit:
            obj.delete()

in delete_existing we have an "obj"
in save_existing we have an "instance"
why it is so? where the difference?

For ModelFormset in admin Inline we have also other instance: parent object. I can expected this "instance (parent)" instead of current "object".

My opinion: attribute name "instance" in save_existing should be changed on "obj"

Change History (1)

comment:1 by Maxim Danilov, 20 months ago

Description: modified (diff)
Summary: wrong variable naming in method BaseModelFormSet.save_existingwrong attribute naming in method BaseModelFormSet.save_existing
Note: See TracTickets for help on using tickets.
Back to Top