Opened 20 months ago

Last modified 20 months ago

#34266 closed New feature

Add ClosestPoint function to GeoDjango — at Version 5

Reported by: Niccolò Mineo Owned by: nobody
Component: GIS Version: dev
Severity: Normal Keywords: geodjango, function
Cc: Paolo Melchiorre Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Niccolò Mineo)

I'd like to suggest adding this function to the bunch to encourage people to prefer its use in a number of situations over cumbersome solutions.

[​​https://github.com/django/django/pull/16449]

Change History (5)

comment:1 by Carlton Gibson, 20 months ago

Cc: Paolo Melchiorre added
Triage Stage: Unreviewed → Accepted

OK, I'll accept this.

At the general level we try include only those function that have wide utility, in order to keep the scope manageable. (It's normally quite easy to add a needed function wrapper to a user's project.)

This seems quite handy to me, so +1, but I'm not a big GeoDjango user up to now, so CCing Paolo (since you are and you already commented on the PR.)

comment:2 by Paolo Melchiorre, 20 months ago

It's fine for me to continue reviewing this PR, I wait for Nicco to integrate the documentation and proceed to review again.

comment:3 by Niccolò Mineo, 20 months ago

Description: modified (diff)

in reply to:  3 comment:4 by Niccolò Mineo, 20 months ago

Replying to Niccolò Mineo:

I've just integrated the change in the release log: ​​https://github.com/django/django/pull/16449. Thanks to you both.

comment:5 by Niccolò Mineo, 20 months ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top