Changes between Initial Version and Version 1 of Ticket #33981, comment 3


Ignore:
Timestamp:
Sep 6, 2022, 6:48:08 AM (2 years ago)
Author:
Andrew Selby

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #33981, comment 3

    initial v1  
    1212
    1313I've identified a minimal set of changes that protect the logic of existing tests, eliminates unnecessary existing requirements and limitations, and removes the unnecessary exception trace from the logs, so that should keep everybody happy.
    14 
    15 
    16 
    17 Replying to [comment:2 Carlton Gibson]:
    18 > Hi Andrew, thanks. There was a pretty clear consensus on the PR to accept this change.
    19 >
    20 > > The other logging calls from response_for_exception() include the exception, it seems to only have been missed here. This allows better debugging and filtering of errors.
    21 >
    22 > ... as such I'm going to close as `wontfix`.
    23 >
    24 > If the traceback bothers you a custom formatter overriding [https://docs.python.org/3/library/logging.html#logging.Formatter.formatException formatException] would likely be the way to go.
Back to Top