Changes between Initial Version and Version 1 of Ticket #33975, comment 7


Ignore:
Timestamp:
Sep 3, 2022, 12:30:19 PM (2 years ago)
Author:
Bhuvnesh

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #33975, comment 7

    initial v1  
    11hi, I am new to Django contribution, i tried to implement the solution proposed by simon, replaced the Query.has_select_fields with has_select_fields attribute with default value False and have set_values set it to true, but now i am stuck at carrying over the attribute to Query.clone , can I get a bit more explanation for the same?
     2**
     3Edit:**
     4Replacing Query_has_select_fields with attribute and having set_values set it to true passes tests for annotations but giving 2 Failures on overall tests .Failures are:
     5
     6FAIL: test_in_subquery (queries.tests.ToFieldTests)
     7
     8AssertionError: Items in the second set but not the first:
     9<Eaten: apple at lunch>
     10
     11
     12FAIL: test_nested_in_subquery (queries.tests.ToFieldTests)
     13
     14AssertionError: Sequences differ: <QuerySet []> != [<ReportComment: ReportComment object (1)>]
     15Second sequence contains 1 additional elements.
     16First extra element 0:
     17<ReportComment: ReportComment object (1)>
Back to Top