Opened 2 years ago

Last modified 2 years ago

#33833 closed Bug

Close button styling issues in admin forms’ submit row — at Version 1

Reported by: Thibaud Colas Owned by: nobody
Component: contrib.admin Version: 4.0
Severity: Normal Keywords: button, focus
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description (last modified by Thibaud Colas)

Picked up as part of reviewing #33728 / ​PR #15734 – in the admin’s submit_line.html / submit-row, the Close button is misaligned:

https://code.djangoproject.com/raw-attachment/ticket/33833/close-button-admin.png

And it has an unexpected underline on focus:

https://code.djangoproject.com/raw-attachment/ticket/33833/close-button-focus.png

The misalignment & other spacing issues are particularly visible when there are multiple buttons displayed, though it’s not clear to me whether this actually happens in practice:

https://code.djangoproject.com/raw-attachment/ticket/33833/close-button-group.png

This is also the case when buttons are displayed vertically in the "mobile" viewports.

---

To reproduce this, access a model form with a user who only has "View" permissions.

Change History (4)

by Thibaud Colas, 2 years ago

Attachment: close-button-admin.png​ added

by Thibaud Colas, 2 years ago

Attachment: close-button-focus.png​ added

by Thibaud Colas, 2 years ago

Attachment: close-button-group.png​ added

comment:1 by Thibaud Colas, 2 years ago

Description: modified (diff)
Note: See TracTickets for help on using tickets.
Back to Top