Django sync_to_async takes infinite time with asgiref 3.5.1+

[parfeniukink]

Django==3.2.13
asgiref==3.5.2

If you will try to decorate any ORM function with sync_to_async you will wait forever.

asgiref==3.5.0 works fine

# models.py
class DTOManager(models.Manager):
    @sync_to_async
    def filter(self, *args, **kwargs) -> list[BaseModel]:
        return [self._dto_mapper(i) for i in self.model.objects.filter(*args, **kwargs)]

    @sync_to_async
    def get(self, *args, **kwargs) -> BaseModel:
        try:
            return self._dto_mapper(self.model.objects.get(*args, **kwargs))
        except self.model.DoesNotExist:
            raise ObjectNotFound(f"{self.model.__name__} not found")

class Hotel(models.Model):
    id = models.UUIDField(primary_key=True, editable=False)
    coordinates = models.PointField(null=True)

    dto_objects = DTOManager(dto_mapper=lambda hotel: HotelDTO(**hotel.curated_data) if hotel else None)
    objects = models.Manager()

# services.py
hotels = await Hotel.dto_objects.filter(id=12)

[Mariusz Felisiak]

Maybe it's not related but I noticed that test_request_lifecycle_signals_dispatched_with_thread_sensitive crashes on the stable/3.2.x branch with asgiref 3.5.1+:

======================================================================
ERROR: test_request_lifecycle_signals_dispatched_with_thread_sensitive (asgi.tests.ASGITest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/django/tests/asgi/tests.py", line 240, in test_request_lifecycle_signals_dispatched_with_thread_sensitive
    target_thread = next(iter(SyncToAsync.single_thread_executor._threads))
StopIteration

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/lib/python3.8/unittest/case.py", line 60, in testPartExecutor
    yield
  File "/usr/lib/python3.8/unittest/case.py", line 676, in run
    self._callTestMethod(testMethod)
  File "/usr/lib/python3.8/unittest/case.py", line 633, in _callTestMethod
    method()
  File "/.virtualenvs/django-test-3.8/lib/python3.8/site-packages/asgiref/sync.py", line 213, in __call__
    return call_result.result()
  File "/usr/lib/python3.8/concurrent/futures/_base.py", line 437, in result
    return self.__get_result()
  File "/usr/lib/python3.8/concurrent/futures/_base.py", line 389, in __get_result
    raise self._exception
  File "/.virtualenvs/django-test-3.8/lib/python3.8/site-packages/asgiref/sync.py", line 279, in main_wrap
    result = await self.awaitable(*args, **kwargs)
RuntimeError: coroutine raised StopIteration

As far as I'm aware these issues are caused by ​asgiref/add57649, however we will not backport 36fa071d6ebd18a61c4d7f1b5c9d17106134bd44 so I would restrict supported version:

setup.cfg

@@ -42 +42 @@
 include_package_data = true
 zip_safe = false
 install_requires =
-    asgiref >= 3.3.2, < 4
+    asgiref >= 3.3.2, < 3.5.1
     pytz
     sqlparse >= 0.2.2
 

[Mariusz Felisiak]

Also, it works for me with Django 3.2.13, asgiref 3.5.2 and Python 3.8.10 🤔.

[Mariusz Felisiak]

Replying to Mariusz Felisiak:

Maybe it's not related but I noticed that test_request_lifecycle_signals_dispatched_with_thread_sensitive crashes on the stable/3.2.x branch with asgiref 3.5.1+

Potential fix: ​PR.