Opened 3 years ago
Last modified 2 years ago
#33589 closed Bug
Incomplete string escaping or encoding — at Initial Version
| Reported by: | Shrikant Dhayje | Owned by: | nobody |
|---|---|---|---|
| Component: | contrib.admin | Version: | 4.0 |
| Severity: | Normal | Keywords: | bug, regex, Inaccurate |
| Cc: | David Wobrock, Sander Beekhuis | Triage Stage: | Unreviewed |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | no |
Description
At
The Given Code
`
390| handleCalendarCallback: function(num) {
391| let format = get_format('DATE_INPUT_FORMATS')[0];
392| the format needs to be escaped a little
393| format = format.replace('
', '
')
394| .replace('\r', '
r')
395| .replace('\n', '
n')
396| .replace('\t', '
t')
`
This replaces only the first occurrence of all the escape characters not all, and as per the the function is unable to completely accurate replacement of string with escape characters.
This replaces only the first occurrence of "", "/r", "/n", "/t" and "'",
So We Should Use regex for replacing all occurrence.
Used regex for easy updating.
This issue "Has patch" https://github.com/django/django/pull/15460