Changes between Initial Version and Version 1 of Ticket #33333, comment 6


Ignore:
Timestamp:
Nov 30, 2021, 2:39:57 PM (3 years ago)
Author:
Simon Charette

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #33333, comment 6

    initial v1  
    11Given we're pretty close to the 4.0 release date I'm not against including a limited hack for `setUpTestData` that special cases `Model` and `QuerySet` instances.
    22
    3 It does feel weird that we're treating this as a release blocker now thought given it has been broken since `BinaryField` was introduced and `setUpTestData` [https://github.com/django/django/commit/3cf80d3fcf7446afdde16a2be515c423f720e54d#diff-7833da5b45a68d00834388d97dd5c4413e3796497c7bc5e0cc2621b08a2d0df1R1108-R1120 has been emitting deprecation warnings about it since Django 3.2].
     3It does feel weird that we're treating this as a release blocker now though given it has been broken since `BinaryField` was introduced and `setUpTestData` [https://github.com/django/django/commit/3cf80d3fcf7446afdde16a2be515c423f720e54d#diff-7833da5b45a68d00834388d97dd5c4413e3796497c7bc5e0cc2621b08a2d0df1R1108-R1120 has been emitting deprecation warnings about it since Django 3.2].
Back to Top