Opened 3 years ago

Last modified 3 years ago

#32959 closed Cleanup/optimization

URLValidator test cases can be defined in a Python module — at Initial Version

Reported by: Chris Jerdonek Owned by: nobody
Component: Testing framework Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

I noticed that the URLValidator tests have a number of test cases defined in separate text files (valid_urls.txt and invalid_urls.txt): https://github.com/django/django/blob/012f38f9594b35743e9ab231757b7b62db638323/tests/validators/tests.py

However, it seems like it would be more maintainable if these test cases were defined in a Python module (e.g. the same tests.py file containing the test code). One reason is that there aren't actually that many test cases to warrant a separate file. Another is that having them as part of a Python module would permit them to be annotated with code comments. Currently, none of the test cases have any comments elaborating on what they're testing, and having them in a text file precludes that possibility. Finally, if there are any concerns about mistranscribing from the text files to a Python module, the transcription could be done with a Python script to eliminate the possibility of transcription errors.

Change History (0)

Note: See TracTickets for help on using tickets.
Back to Top