Changes between Initial Version and Version 1 of Ticket #32958, comment 3


Ignore:
Timestamp:
Jul 22, 2021, 11:44:29 AM (3 years ago)
Author:
Chris Jerdonek

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #32958, comment 3

    initial v1  
    44
    55The second was to add e.g. a context manager around each validation test case to check that the validation doesn't take longer than some amount of time. That would serve to check that it doesn't take forever. If the time is generous enough (e.g. 1 second?), there shouldn't be any risk of flakiness. (Unlike with other flaky tests, there is no I/O happening here.) If forever is truly minutes or hours, then even 60 seconds could work. But I think that might be unnecessarily generous.
     6
     7If the second change isn't done (though I think it should), then I think the comment should be updated to clarify how this is being checked / what failure looks like, e.g. "Trailing junk does not take forever to reject (minutes, maybe hours). The test suite will hang indefinitely in this case." That was what originally confused me -- I couldn't see how this was being checked by looking at the code.
Back to Top