Changes between Version 1 and Version 2 of Ticket #32508, comment 23


Ignore:
Timestamp:
Jun 2, 2021, 10:29:07 PM (3 years ago)
Author:
Jacob Walls

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #32508, comment 23

    v1 v2  
    44Thanks for your interest. Daniyal handled the bulk of what was left here in [https://github.com/django/django/pull/14173 PR 14173], so if you want to tackle the rest, be sure to skip the django.db module, which was the focus of that PR.
    55
    6 Toward getting started, this is a great time to learn about grep, e.g. `grep 'assert\s' django/* -r`. Below is what's left excluding django.db and the test suite itself.
     6Toward getting started, this is a great time to learn about grep, e.g. `grep 'assert\s' django/* -r`. Below is what's left excluding django.db (and django.utils, already reviewed in 775b796d8d13841059850d73986d5dcc2e593077) and the test suite itself.
    77
    88The work to finish this off is to decide which ones remaining are worth changing given comments above from Tim and Chris. I suspect not many. The last one in the list could be; it's potentially user-facing and already has a nice exception message, so we can just change to `TypeError`. The ones in contrib.auth.hashers look like sanity checks we don't need to touch.
    … …  
    3636django/test/utils.py:            assert not args
    3737django/test/testcases.py:        assert not self.reset_sequences, 'reset_sequences cannot be used on TestCase instances'
    38 django/utils/version.py:        assert len(version) == 5
    39 django/utils/version.py:        assert version[3] in ('alpha', 'beta', 'rc', 'final')
    40 django/utils/regex_helper.py:            assert not flags, (
    4138django/views/decorators/debug.py:            assert isinstance(request, HttpRequest), (
    4239}}}
Back to Top