Changes between Initial Version and Version 1 of Ticket #32348, comment 8


Ignore:
Timestamp:
Jan 15, 2021, 11:47:43 AM (4 years ago)
Author:
Guan

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #32348, comment 8

    initial v1  
    44Hi! Thanks for your work. But there are probably two slight flaws I think:
    55 1. When ValidationError is raised, it's no 'X' at the top right of form. That the UX is not comfortable is ticket #29087 talked about.
    6  2. For {{{toggleDeleteButtonVisibility}}} function,  my option comes from [https://docs.djangoproject.com/en/3.1/intro/tutorial07/ **extra** form could not be removed] and [https://docs.djangoproject.com/en/3.1/topics/forms/formsets/ if a formset contains no data, then extra + min_num empty forms will be displayed]. So the calculation I think is：
     6 2. For {{{toggleDeleteButtonVisibility}}} function,  my opinioncomes from [https://docs.djangoproject.com/en/3.1/intro/tutorial07/ **extra** form could not be removed] and [https://docs.djangoproject.com/en/3.1/topics/forms/formsets/ if a formset contains no data, then extra + min_num empty forms will be displayed]. So the calculation I think is：
    77{{{
    88const isFormOverload = function() {                                                                                                                                                                                       
    … …  
    2222When {{{isFormOverload}}} returns true, all forms show 'X'.
    2323
    24 I created patch [https://github.com/hramezani/django/pull/1 PR] and I'd like to know your option.
     24I created patch [https://github.com/hramezani/django/pull/1 PR] and I'd like to know your opinion.
Back to Top