Changes between Version 2 and Version 3 of Ticket #32329, comment 4


Ignore:
Timestamp:
Jan 16, 2021, 8:05:46 PM (4 years ago)
Author:
Tim McCurrach

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #32329, comment 4

    v2 v3  
    3636 - Ignore the file? (probably not, since this would lead to pretty confusing and hard to debug behaviour)
    3737
    38 Either way, I think we should probably add a check that if `FILE_UPLOAD_TEMP_DIR` is set then it also exists.
     38Either way, I think we should probably add a check that if `FILE_UPLOAD_TEMP_DIR` is set then it also exists (EDIT: I've just seen this was suggested above).
    3939
    4040If we did add such a check, could we ignore handling `OSError`s in `TemporaryUploadedFile.__init__`? My immediate feeling is that even if a check would mitigate this particular error, there are probably other errors that could occur here, and letting them bubble up to wherever they happen to get caught is confusing and difficult to debug. As such, a decision is needed as to how they should be handled.
Back to Top